Refactor: Update GrafanaDatasource reconcile loop
#1826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Baarsgaard
force-pushed
the
update_datasource_reconcile_loop
branch
from
5135ecd to
8e81036
Compare
Baarsgaard
force-pushed
the
update_datasource_reconcile_loop
branch
2 times, most recently
from
5b51f51 to
8fb05de
Compare
Baarsgaard
requested review from
NissesSenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
Baarsgaard
force-pushed
the
update_datasource_reconcile_loop
branch
from
8fb05de to
5684fe8
Compare
feat: NoMatchingInstances condition
refactor: Call Update Status once in Defer feat: Add NoMatchingInstances condition
…ptional test: Verify spec.Datasource is never nil
chore: Update Datasource finalize function
test: Fix e2e assert failing after lastMessage deprecation
refactor: BuildDatasourceModel aligned with contactpoint
Baarsgaard
force-pushed
the
update_datasource_reconcile_loop
branch
from
5684fe8 to
db33aa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a significantly more complex rewrite than earlier reconcile loops simply due to how different the controller was written.
I recommend to review this one commit at a time and to have at least 2 separate reviewers verify it due to the amount of changes.
I had to split
finalizeinto two separate functions to get past a nasty "Not found" error loop that is correct on an updated uid, but a problem when trying to delete a crd.I would like some comments on whether
ReconcilePluginsis needed in both or just finalize?See commit messages for detailed changes.
This should close #1681 and tick off GrafanaDatasource on #1450